-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title
to setSuggestedPrompts utility
#2308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions but LGTM overall
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2308 +/- ##
=======================================
Coverage 92.48% 92.49%
=======================================
Files 36 36
Lines 7466 7472 +6
Branches 651 651
=======================================
+ Hits 6905 6911 +6
Misses 553 553
Partials 8 8 ☔ View full report in Codecov by Sentry. |
@@ -57,23 +57,20 @@ const config = { | |||
redirects: [ | |||
{ | |||
to: '/getting-started', | |||
from: ['/tutorial/getting-started','/tutorial/getting-started-http'], | |||
from: ['/tutorial/getting-started', '/tutorial/getting-started-http'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukegalbraithrussell 👋🏼 When you make docs changes, make sure to run the linter so these aren't picked up by subsequent PRs. It'll help us keep the changes for each PR scoped to what they're actually about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm i think maybe i ran the wrong linter because it changed all of this just in my last PR. (Most notably in that sidebar.js file -- I would never manually use double quotations willingly so i remember it changing them all). I'll figure out what happened
Summary
Updates
setSuggestedPrompts
to include an optionaltitle
property:Requirements (place an
x
in each[ ]
)